fix: emit base team-member grant for maintainers#160
Open
c1-dev-bot[bot] wants to merge 1 commit into
Open
Conversation
When a team member holds a non-default role (e.g., maintainer), the GitHub API filters them out of the member role query. This means maintainers only received a grant on the maintainer entitlement, never on the base team-member entitlement, causing under-counted membership. Now, when processing maintainer role results, we also emit a team-member grant for each user so the membership view matches GitHub's own model where every maintainer is also a member. Fixes: CXH-1513
Contributor
Connector PR Review: fix: emit base team-member grant for maintainersBlocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0 Review SummaryThis PR adds a synthetic Security IssuesNone found. Correctness IssuesNone found. SuggestionsNone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ListTeamMembersByIDAPI filters them out ofrole=memberresults. This caused maintainers to only receive a grant on the maintainer entitlement, never on the base team-member entitlement — under-counting membership.teamRoleMembergrant for every user returned by the maintainer role query, so all team members appear under the base membership entitlement regardless of their elevated role.Test plan
memberandmaintainerentitlements for those usersmemberrole still receive exactly onemembergrant (no duplicates)team-grant:<team>:<user>:memberandteam-grant:<team>:<user>:maintainer)Fixes: CXH-1513
Automated PR Notice
This PR was automatically created by c1-dev-bot as a potential implementation.
This code requires: